-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix page titles and add microsoft favicon #112
base: master
Are you sure you want to change the base?
Conversation
not familiar with that favicon URL. Can you try to find an official version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update favicon
Also, it looks like you checked in a TON of changes that are simply whitespace updates. Can you only submit actual code changes. |
wouldn't hurt to import an svg or official icon into the |
i actually got the favicon from the microsoft website anws, i'll be changing it and add an svg in the assets folder, also i might be reverting it back and redo the changes i wasn't really also sure what caused the reformatting, i would also try to check on that |
actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟 |
can you turn off prettier in vscode and try to revert those changes? |
I actually did the other way around and committed a better version of it at 6aa2825 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the favicon
Added titles to the pages and somewhat added a favicon w/c is the microsoft logo from microsoft.com