Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Added ZRANGESTORE command #826

Merged
merged 15 commits into from
Dec 8, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the ZRANGESTORE command to garnet

  • Add ZRANGESTORE command
  • Add Integration Test cases, ACL Test and Slot Verification Test
  • Add documentation

@TalZaccai TalZaccai self-requested a review November 26, 2024 19:09
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation! Please see comments.

libs/server/API/IGarnetApi.cs Outdated Show resolved Hide resolved
libs/server/Storage/Session/ObjectStore/SortedSetOps.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespSortedSetTests.cs Show resolved Hide resolved
test/Garnet.test/RespSortedSetTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespSortedSetTests.cs Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Please rereview it, I am not sure about the one open command

@TalZaccai TalZaccai merged commit 4e7cc74 into microsoft:main Dec 8, 2024
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/ZRANGESTORE-command branch December 9, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants