Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Added COMMAND GETKEYS and GETKEYSANDFLAGS command #888

Merged
merged 16 commits into from
Jan 21, 2025
Merged

[Compatibility] Added COMMAND GETKEYS and GETKEYSANDFLAGS command #888

merged 16 commits into from
Jan 21, 2025

Conversation

Vijay-Nirmal
Copy link
Contributor

@Vijay-Nirmal Vijay-Nirmal commented Dec 18, 2024 •
edited
Loading

Adding the COMMAND GETKEYS and GETKEYSANDFLAGS command to garnet

  • Add COMMAND GETKEYS and GETKEYSANDFLAGS commands
  • Add Integration Test cases and ACL Test
  • Add documentation

TalZaccai
TalZaccai requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! Added a few comments.

libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/BasicCommands.cs Outdated Show resolved Hide resolved
playground/CommandInfoUpdater/CommandDocsUpdater.cs Outdated Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Fixed all review commands

TalZaccai
TalZaccai requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the recent fixes! Added some extra comments.

libs/resources/RespCommandsDocs.json Show resolved Hide resolved
libs/server/Resp/Parser/SessionParseStateExtension.cs Outdated Show resolved Hide resolved
libs/server/Resp/Parser/SessionParseStateExtension.cs Outdated Show resolved Hide resolved
libs/server/Resp/Parser/SessionParseStateExtension.cs Outdated Show resolved Hide resolved
libs/server/Resp/Parser/SessionParseStateExtension.cs Outdated Show resolved Hide resolved
libs/server/Resp/RespCommandKeySpecification.cs Outdated Show resolved Hide resolved
libs/server/Resp/RespCommandKeySpecification.cs Outdated Show resolved Hide resolved
libs/server/Resp/RespCommandKeySpecification.cs Outdated Show resolved Hide resolved
libs/server/Resp/RespCommandKeySpecification.cs Outdated Show resolved Hide resolved
libs/server/Resp/RespCommandKeySpecification.cs Outdated Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Fixed all review comments

@TalZaccai TalZaccai merged commit 1bb4069 into microsoft:main Jan 21, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vijay-Nirmal @TalZaccai