Refactor paginatorToArray to use AsyncIterable instead of AsyncIterableIterator #786
Annotations
3 errors
|
packages/core/src/github.ts#L414
The change from `AsyncIterableIterator<T>` to `AsyncIterable<T>` may cause issues if the `iterator` object was being used with `next()` method, which is not available on `AsyncIterable<T>`. Please ensure that the `iterator` object is only being used for iteration and not for manual control of the iteration process. 🧐
|
|
packages/core/src/github.ts#L414
The change in type may affect the functionality of the `paginatorToArray` function. If the function was expecting an `AsyncIterableIterator<T>`, changing it to `AsyncIterable<T>` might break the function if it was using properties or methods specific to `AsyncIterableIterator<T>`. Please ensure that the function can handle `AsyncIterable<T>` without any issues. 😊
|
|
packages/core/src/github.ts#L414
The change in the type of the `iterator` parameter in the `paginatorToArray` function has been made without any explanation or review comments. It would be helpful to provide a rationale for this change to help reviewers understand the intent behind it. This can also help in catching potential issues that might arise due to this change. 😇
|
This job succeeded
Loading