don't reference promptfoo as dep #602

pelikhan · 2024-08-05T15:06:21Z

🔄 Several packages across multiple package.json files have been updated. These include "@azure/identity", "file-type", "openai", and "web-tree-sitter". This could mean that newer versions of these packages have bug fixes, new features, or performance improvements that the project can benefit from.
💻 Inside the docs/src/content/docs/reference/cli/commands.md, the default promptfoo version for the CLI command has been updated from ^0.73.9 to ^0.75.0.
🧪 In packages/cli/src/test.ts, the import for OutputFile from promptfoo has been removed and the assignment of value no longer casts the parsed JSON as OutputFile.
🔀 The PROMPTFOO_VERSION in packages/cli/src/version.ts now points to the devDependencies section of package.json instead of the dependencies section.
🆙 The Vue version in slides/package.json has been updated from ^3.4.34 to ^3.4.35.
💡 No changes detected in the public API as defined in "packages/core/src/prompt_template.d.ts" and "packages/core/src/prompt_type.ts". Therefore, these changes are not user-facing and are likely internal improvements or updates.

generated by pr-describe

packages/cli/src/test.ts

packages/cli/src/version.ts

packages/cli/src/test.ts

github-actions · 2024-08-05T15:08:11Z

The changes in GIT_DIFF show two main modifications in the test.ts and version.ts files:

In test.ts, the import line for { OutputFile } from "promptfoo" has been removed. Later in the file, the type assertion as OutputFile has also been removed. This suggests that the OutputFile type is no longer needed in this file, possibly due to changes in another part of the code base. This change seems fine as long as it aligns with changes in other parts of the project.
In version.ts, the PROMPTFOO_VERSION is now being taken from packageJson.devDependencies.promptfoo instead of packageJson.dependencies.promptfoo. This implies that promptfoo is now a development dependency rather than a production dependency. This can be a concern if promptfoo is still used in the production environment.

Please ensure that promptfoo is not needed in the production build, otherwise, it should stay in the dependencies. If it is only used during development or testing, then this change is correct.

In summary, if the changes align with the overall changes in the project, then LGTM 🚀. But do ensure the correct placement of promptfoo in the dependencies.

generated by pr-review

docs/src/content/docs/reference/cli/commands.md

packages/cli/src/test.ts

packages/cli/src/version.ts

packages/cli/src/test.ts

packages/core/src/connection.ts

docs/src/content/docs/getting-started/configuration.mdx

packages/core/src/connection.ts

github-actions · 2024-08-05T15:41:27Z

docs/src/content/docs/getting-started/configuration.mdx

@@ -141,6 +142,7 @@ GENAISCRIPT_DEFAULT_MODEL=openai:gpt-4o
 :::

 ## GitHub Models
+
 <a id="github" href=""></a>


Anchor link is missing URL for GitHub Models section.

generated by pr-docs-review-commit anchor_link_missing

github-actions · 2024-08-05T15:41:28Z

docs/src/content/docs/getting-started/configuration.mdx

 ## Azure OpenAI
+
 <a id="azure" href=""></a>


Anchor link is missing URL for Azure OpenAI section.

generated by pr-docs-review-commit anchor_link_missing

github-actions · 2024-08-05T15:41:29Z

docs/src/content/docs/reference/cli/commands.md

@@ -87,7 +87,7 @@ Options:
  -td, --test-delay <string>          delay between tests in seconds
  --no-cache                          disable LLM result cache
  -v, --verbose                       verbose output
-  -pv, --promptfoo-version [version]  promptfoo version, default is ^0.73.9
+  -pv, --promptfoo-version [version]  promptfoo version, default is ^0.75.0


Option name mismatch, should be '--prompt-version' instead of '--promptfoo-version'.

generated by pr-docs-review-commit option_name_mismatch

don't reference promptfoo as dep

258b9e7