connection tree view #616
connection tree view #616
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -152,6 +152,7 @@ export class NodeHost implements RuntimeHost { | |||
| const { signal, token: askToken } = options || {} | |||
| await this.parseDefaults() | |||
| const tok = await parseTokenFromEnv(process.env, modelId) | |||
| if (!askToken && tok?.token) tok.token = "***" | |||
There was a problem hiding this comment.
The promise returned by parseTokenFromEnv function is not handled. Consider using await or .then to handle the promise.
generated by pr-review-commit
unhandled_promise
| await this.state.host.server.client.getLanguageModelConfiguration( | ||
| element.provider + ":*", | ||
| { token: false } | ||
| ) |
There was a problem hiding this comment.
The promise returned by getLanguageModelConfiguration function is not handled. Consider using await or .then to handle the promise.
generated by pr-review-commit
unhandled_promise
| @@ -226,7 +225,7 @@ export function createChatModelRunner( | |||
| text += fragment | |||
| onChunk({ | |||
| chunk: fragment, | |||
| tokens: await chatModel.countTokens(text), | |||
| tokens: await chatModel.countTokens(fragment), | |||
There was a problem hiding this comment.
The promise returned by countTokens function is not handled. Consider using await or .then to handle the promise.
generated by pr-review-commit
unhandled_promise
|
The changes in the pull request mostly seem fine and should improve the functionality of the code. However, I do have a concern about the following change in - tokens: await chatModel.countTokens(text),
+ tokens: await chatModel.countTokens(fragment),In the original version, If this change was intentional and you're aware that the token count will no longer consider previous fragments, then the change is fine. But if you meant to keep counting tokens for the full text, you should revert to the original line. Here's the suggested fix: - tokens: await chatModel.countTokens(fragment),
+ tokens: await chatModel.countTokens(text),If everything else is in order, and the above change was intentional or is acceptable, then LGTM 🚀
|
|
/genai-describe |
| # GITHUB_MODELS_TOKEN="${PLACEHOLDER_API_KEY}" # use a personal access token if not available | ||
| ## GitHub Models ${DOCS_CONFIGURATION_GITHUB_URL} | ||
| # use "${MODEL_PROVIDER_GITHUB}:<model>" in script({ model: ... }) | ||
| # GITHUB_MODELS_TOKEN="${PLACEHOLDER_API_KEY}" # use a personal access token if not available |
There was a problem hiding this comment.
The comments are not properly indented. Comments should be aligned with the code they are commenting on.
generated by pr-review-commit
comment_format
display connection information in a tree view
A key secret masking mechanism has been input in the
packages/cli/src/nodehost.tsfile to ensure that tokens are not plainly accessible. Secure move! 🔒In
packages/core/src/connection.ts, the document formatting has been adjusted with indentation being eliminated. Quite a neat up! 🙂The
packages/sample/genaisrc/pr-review.genai.jsfile has been modified to include the instruction not to annotate individual lines of code, but to summarize changes. Better clarity! 👌New updates have been introduced in the
packages/vscode/package.json. This includes the addition of Connections under viewContainers and connection-configuration related settings under commands. New capabilities brewing!🎉A new file,
packages/vscode/src/connectioninfotree.ts, has been brought in. It contains classes that handle connection information within a tree structure for a better hierarchical organization. Power of OOP! 🎯The extension activation process found in
packages/vscode/src/extension.tshas been extended by incorporating ConnectionInfoTree state. Also, it includes a command to configure connections. More flexibility and control here! 👏The
packages/vscode/src/lmaccess.tsfile indicates the implementation of a function to count tokens for each text chunk rather than the whole text. This possibly enhances performance! 🚀Remember, changes in "packages/core/src/prompt_template.d.ts" and "packages/core/src/prompt_type.ts" directly affect users but there are no modifications related to these files in this diff. 📚