-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for agentic ai providers #655
Conversation
- [Midjourney](https://agentic.so/tools/midjourney) | ||
- [Novu](https://agentic.so/tools/novu) | ||
- [People data-labs](https://agentic.so/tools/people-data-labs) | ||
- [People data labs](https://agentic.so/tools/people-data-labs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect hyphenation in the URL, it should be 'people-data-labs' instead of 'People data labs'.
generated by pr-docs-review-commit
incorrect_hyphenation
The pull request contains changes to three TypeScript files, with alterations focusing on function definitions, function calls, and data types.
Concerns:
Overall, the changes seem sound and should enhance the flexibility of the code. LGTM 🚀
|
packages/core/src/chat.ts
Outdated
typeof output === "number" || | ||
typeof output === "boolean" | ||
) | ||
toolContent = "" + output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using "" + output
for type conversion. It's better to use String(output)
for clarity and performance. 🚀
generated by pr-review-commit
type_conversion
@@ -218,7 +222,7 @@ ${stderr || ""}` | |||
${fenceMD(content, " ")} | |||
` | |||
} else { | |||
toolContent = (output as ToolCallContent)?.content | |||
toolContent = YAMLStringify(output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function YAMLStringify
is imported but not defined anywhere in the changes. Please ensure it is correctly defined and imported. 🧐
generated by pr-review-commit
missing_function
tool.spec.parameters as any, | ||
tool.impl | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The defTool
function has become quite complex with multiple nested conditions and loops. Consider refactoring it into smaller, more manageable functions. This will improve readability and maintainability. 📚
generated by pr-review-commit
complexity
docs/guides/agentic-tools.mdx
, removing and updating several links to agentic tools.chat.ts
, notably by simplifying thefind()
method and enhancing the output handling.runpromptcontext.ts
by accommodatingToolCallback
,AgenticToolCallback
, andAgenticToolProviderCallback
indefTool
function.prompt_template.d.ts
andprompt_type.ts
defining newAgenticToolProviderCallback
that includes a collection ofAgenticToolCallback
.agentic-calculator.genai.mts
sample code.agentic-tools.genai.mts
which illustrates the usage of multiple agentic tools including calculator and weather tools.package.json
in the sample package to include a new developer dependency@agentic/weather
.