-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keys method to WorkspaceFileCache #676
Conversation
The changes in the pull request add a new method to the In In terms of function, this change allows users of the file system cache to retrieve an array of the cache's keys without having to retrieve the whole entries. This could be more performant in cases where only the keys are needed. There are no apparent functional issues with these changes. However, as a code reviewer, I can't guarantee the correctness of the method because the actual implementation of the Overall, this change is LGTM 🚀. It adds a useful function to the file system interface that improves its flexibility and potential efficiency.
|
This pull request adds a
keys
method to theWorkspaceFileCache
interface. Thekeys
method returns a promise that resolves to an array of keys in the cache. This allows users to retrieve a list of keys stored in the cache. The changes also include updating the documentation to reflect the new method.WorkspaceFileCache
interface, in the file "packages/core/src/types/prompt_template.d.ts". This new method allows to get all the keys from the cache. Now you can list the keys in the cache as well as the values. 🔑⚡keys
method is used to fetch all the keys from the cache. 📄🔄keys
method. This is expected to help the users of the public API to learn how to get a list of keys from the cache memory. 📖🔍