Move cancel function implementation from promptcontext to globals

[pelikhan]

• The cancel method has been moved from the PromptContext object to the global scope of the application. This is evident from the changes in 'packages/core/src/globals.ts' and 'packages/core/src/promptcontext.ts' files. This could be to make cancel functionality universally accessible. 🌎
• Consequently, the cancel method was removed from the PromptContext interface definition in the 'packages/core/src/types/prompt_template.d.ts' file. This is a user facing change as it modifies how users interact with the 'PromptContext' interface. ⚠️
• The createPromptContext function no longer throws a CancelError exception; this responsibility seems to have been shifted to the moved cancel method. Therefore, the code might be becoming more modular or adhering to separation of concerns principle. 📏
• Note, no other functions or methods were introduced or significantly altered, indicating the primary purpose of these changes was around organizing handling of cancel operations. ♻️

generated by pr-describe

[github-actions]

You are throwing a new CancelError in the cancel function but it's not being caught anywhere. This could lead to an unhandled promise rejection. Please make sure to catch this error where the cancel function is being called. 🚀

generated by pr-review-commit unhandled_rejection

[github-actions]

The cancel function has been removed from the PromptContext. If this function was being used elsewhere in the code, it could lead to a TypeError of cancel is not a function. Please ensure that the cancel function is not being used elsewhere in the code or provide an alternative implementation. 🧐

generated by pr-review-commit removed_functionality

[github-actions]

The cancel method has been removed from the PromptContext interface. This change could break existing implementations that rely on this method. Please ensure that this change is intentional and that all implementations of this interface have been updated accordingly. 🕵️‍♀️

generated by pr-review-commit interface_change

[github-actions]

The changes in the GIT_DIFF involve two main adjustments in the TypeScript code:

1. In globals.ts, the installGlobals method has been updated to include a cancel function that throws a CancelError. This is a new global function available to the rest of the code.

2. In promptcontext.ts, several import statements have been removed, and the previously defined cancel function in the createPromptContext method has also been removed. This suggests that the global cancel function in globals.ts will replace the local cancel function previously defined here.

3. In prompt_template.d.ts, the cancel method has been removed from the PromptContext interface.

There don't appear to be any major issues with these changes. It looks like a refactoring effort to globalize the cancel function and reduce code duplication. However, there are some points to consider:

• The CancelError being thrown in globals.ts has a default message user cancelled. This might take away some granularity in error reporting if different parts of the code relied on specific error messages when cancellation occurs.
• There might be a potential side effect if any code relies on the absence of a cancel method in PromptContext interface as a condition.

Otherwise, LGTM 🚀

generated by pr-review