Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in API requests #753

Closed
wants to merge 2 commits into from
Closed

Improve error handling in API requests #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
881b5ea
Add local files to .gitignore
pelikhan Oct 3, 2024
1543fc1
Add comment to git.ts in GitClient class
pelikhan Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ yarn-error.log
test.sh
esbuild.*.json
esbuild.*.html
*.local.*
1 change: 1 addition & 0 deletions packages/core/src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@
unified?: number
llmify?: boolean
}): Promise<string> {
// change

Check failure on line 230 in packages/core/src/git.ts

View workflow job for this annotation

GitHub Actions / build 

The comment `// change` has been added but there is no actual code change. Please ensure to implement the intended functionality. 😊

Check failure on line 230 in packages/core/src/git.ts

View workflow job for this annotation

GitHub Actions / build 

The comment `// change` is ambiguous and does not provide any context about the intended change. Please provide more descriptive comments. 📝

Check failure on line 230 in packages/core/src/git.ts

View workflow job for this annotation

GitHub Actions / build 

The comment `// change` seems unnecessary as it does not provide any useful information about the code. Consider removing it or replacing it with a more descriptive comment. 👍
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment // change has been added but there is no actual code change. Please ensure to implement the intended functionality. 😊

generated by pr-review-commit missing_functionality

pelikhan marked this conversation as resolved.
Show resolved Hide resolved
pelikhan marked this conversation as resolved.
Show resolved Hide resolved
const paths = arrayify(options?.paths, { filterEmpty: true })
const excludedPaths = await this.resolveExcludedPaths(options)
const { staged, base, head, unified, askStageOnEmpty } = options || {}
Expand Down