Refactor: Remove file validation and add sample scripts #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -367,8 +367,7 @@ export async function runScript( | |||
| if (isJSONLFilename(outData)) await appendJSONL(outData, result.frames) | |||
| else await writeText(outData, JSON.stringify(result.frames, null, 2)) | |||
|
|
|||
| if (result.status === "success" && result.fileEdits && applyEdits) | |||
| await writeFileEdits(result.fileEdits, { trace }) | |||
| await writeFileEdits(result.fileEdits, { applyEdits, trace }) | |||
There was a problem hiding this comment.
The result.fileEdits and applyEdits are not checked before calling writeFileEdits. This could lead to unexpected behavior if result.fileEdits is undefined or applyEdits is false.
generated by pr-review-commit
missing_check
packages/core/src/fileedits.ts
Outdated
| // Iterate over each file edit entry | ||
| for (const fileEdit of Object.entries(fileEdits || {})) { | ||
| // Destructure the filename, before content, after content, and validation from the entry | ||
| const [fn, { before, after, validation }] = fileEdit | ||
|
|
||
| if (!applyEdits && !validation?.valid) { |
There was a problem hiding this comment.
The condition !applyEdits && !validation?.valid will never be true because if applyEdits is false, the function will not be called due to the missing check in run.ts. This could lead to unexpected behavior.
generated by pr-review-commit
logic_error
| // TODO: implement fibonacci algorithm | ||
| return 0 // BODY | ||
| } // this one needs to go | ||
| // another comment |
There was a problem hiding this comment.
The function fibonacci is not implemented and will always return 0. This could lead to incorrect results.
generated by pr-review-commit
unimplemented_code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the file validation logic that was previously responsible for checking file outputs against specified schemas and patterns. In its place, several sample scripts have been added to demonstrate functionality and provide a clearer structure for future development. The changes aim to simplify the codebase and enhance usability by focusing on practical examples.