files accept hint #984
Merged
files accept hint #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -32,5 +32,5 @@ export function lookupMime(filename: string) { | |||
| if (/\.astro$/i.test(filename)) return "text/x-astro" | |||
|
|
|||
| // Default to lookup from 'mime-types' or return empty string | |||
| return mimeTypesLookup(filename) || "" | |||
| return mime.getType(filename) || "" | |||
There was a problem hiding this comment.
Consider using a more specific MIME type lookup function to avoid potential issues with file extensions.
AI-generated content by pr-review-commit
mime_type_lookupmay be incorrect
|
LGTM 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Key Changes 🚀
File Extensions Filter:
acceptproperty to thescriptoptions, allowing filtering of file extensions based on provided comma-separated values. This feature enhances flexibility and control over accepted file types.Enhanced Schema Properties:
acceptstrings to an object mapping MIME types to their associated file extensions. This simplifies schema handling by associating files with appropriate MIME types dynamically.Improved User Interface Features:
underscorefunction, transforming field names into more readable formats, enhancing readability and user experience in UI components.Updated File Drop Zone Logic:
acceptfunctionality, adjusting the logic to handle multiple files based on their MIME types, which improves usability when accepting specific file types.API Stability: