Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid SetFileCompletionNotificationModes crash #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zanderz
Copy link

@zanderz zanderz commented Oct 30, 2018

According to Microsoft's own documentation, there is a known bug where SetFileCompletionNotificationModes crashes on some systems (see https://support.microsoft.com/kb/2568167 for details) and a user of ours has experienced this with our software. This adapts the precautions added to Golang itself (https://go-review.googlesource.com/c/go/+/69870/).
@maxtaco

@msftclas
Copy link

msftclas commented Oct 30, 2018

CLA assistant check
All CLA requirements met.

@mei-rune
Copy link

any progress

@TBBle
Copy link
Contributor

TBBle commented Jan 2, 2021

Does this also replace #27, fixing #26? If I'm reading the Golang-side change, it also handles Windows XP, so I expect the answer is "yes". I'm not sure how it handles XP though.

I'm also curious why the second hunk from #27 wasn't needed here, the change in asyncIo, performing the result-wait even if err was not syscall.ERROR_IO_PENDING.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants