Skip SHA test that require marshaling #1384
Open
+154
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
microsoft-golang-review-bot and
a team
as code owners
mertakman
approved these changes
Oct 31, 2024
dagood
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
We might want to have a test that specifically makes sure we don't unintentionally remove marshaller support from specific OpenSSL backend scenarios... but that's probably the role of scenario testing because here we're simply doing the best we can per-platform.
| } | ||
|
|
||
| h := tt.new() | ||
| + if _, ok := h.(encoding.BinaryMarshaler); !ok { |
There was a problem hiding this comment.
Missing if boring.Enabled {? (Just looking at the pattern, haven't checked the context beyond the cutoff. 😄)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenSSL providers (looking at you SymCrypt) don't support marshaling the internal state of the hash function. There are some tests that require that functionality to succeed. We were previously skipping those tests when using the CNG backend, which doesn't implement digest marshaling. This PR generalizes the way we detect that a given digest doesn't support marshaling so it also works for OpenSSL.