Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
shim: Clean up delete invocation behavior
This changes the behavior when the shim is invoked with the "delete" command line argument. Previously, the delete path did two things it should not: - Attempted to locate the sandbox container for the pod and delete it as well. This meant if "shim delete" was invoked for a workload container, it could bring down the whole pod. The only reason we did not see this in the past is that prior to containerd 1.5 "shim delete" was not called for successful container stop operations. - Deleted the bundle directory. We shouldn't do this in the shim, as containerd does it itself. For reference on what the Linux shim does, see here: https://github.com/containerd/containerd/blob/master/runtime/v2/runc/v2/service.go#L291 Signed-off-by: Kevin Parsons <[email protected]> (cherry picked from commit 450cdb1) Signed-off-by: Kevin Parsons <[email protected]>
- Loading branch information