-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poison queues support for RabbitMQ #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of minor changes. I haven't tested/fully reviewed the logic yet
Co-authored-by: Devis Lucato <[email protected]>
I have updated this PR using Quorum Queues and Dead Letter Queues. There are a couple of issues:
this._channel.QueueDeclare(
queue: this._queueName,
durable: true,
exclusive: false,
autoDelete: false,
arguments: new Dictionary<string, object>
{
["x-queue-type"] = "quorum",
["x-delivery-limit"] = this._config.MaxRetriesBeforePoisonQueue,
["x-dead-letter-exchange"] = poisonExchange
}); The delivery limit cannot be changed, otherwise an exception will be thrown. So, we cannot modify the value of
|
Hi @dluc! |
not yet sorry, other projects keeping me busy. I don't know when I'll be able to look through this - I'm hoping to merge the streaming PRs first, to improve the end user experience |
Hi @dluc, Given that it is not possible to change the x-delivery-limit value after queue creation, I have added a Let me know if it could be a solution. |
@dluc, GitHub signals that this PR has 1 change requested, but it seems that all the request changes have been addressed, or am I missing something? |
@marcominerva I think the PR is ready, sorry about the long delay. About the issue with max retries, I think we can live with it for now. The only option I see would be removing "x-delivery-limit" and handling the count manually, checking the "x-delivery-count" header. It would be easy, but let's see if anyone complains about this first.
|
Motivation and Context (Why the change? What's the scenario?)
See #408.