Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SK text and embedding generator wrappers public #808

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented Sep 27, 2024

Currently it's possible to inject Semantic Kernel classes into KM only using

  • IKernelMemoryBuilder.WithSemanticKernelTextGenerationService
  • IKernelMemoryBuilder.WithSemanticKernelTextEmbeddingGenerationService
  • IServiceCollection.AddSingleton(instance)
  • IServiceCollection.AddSingleton(instance)

However, it's not possible to create an instance of Semantic Kernel classes directly without writing a custom wrapper class first. Since the project already includes such wrapper, as internal classes, this PR changes them to public classes, to reduce the amount of code to write.

Classes:

  • SemanticKernelTextGenerator
  • SemanticKernelTextEmbeddingGenerator

@dluc
Copy link
Collaborator Author

dluc commented Sep 27, 2024

See also #801

@dluc dluc merged commit 0d3e6f4 into microsoft:main Sep 27, 2024
6 checks passed
@dluc dluc deleted the skpublicclasses branch September 27, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant