Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PXE boot support on QEMU Q35 #727

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Oct 6, 2023

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

This change added some input options to allow local emulation of PXE boot.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This was tested on QEMU Q35 platform and can boot to locally setup PXE folder properly.

Integration Instructions

TBD

@github-actions github-actions bot added the language:python Pull requests that update Python code label Oct 6, 2023
@kuqin12 kuqin12 marked this pull request as ready for review October 27, 2023 19:06
@github-actions github-actions bot added type:documentation Improvements or additions to documentation impact:security Has a security impact labels Oct 27, 2023
@@ -829,7 +829,8 @@ InitializePlatform (

MmSettings.HeapGuardPolicy.Fields.MmPageGuard = 1;
MmSettings.HeapGuardPolicy.Fields.MmPoolGuard = 1;
DxeSettings.ImageProtectionPolicy.Fields.ProtectImageFromUnknown = 1;
// Note: This is to leave a place holder for iPXE option rom...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot work around this for oprom... Open for other suggestions.

@kuqin12 kuqin12 requested a review from cfernald October 27, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:security Has a security impact language:python Pull requests that update Python code type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant