Allow some known extra inputs in the model #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RyanUnderhill
approved these changes
Jan 9, 2025
|
Thank you for the review :) |
baijumeswani
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds some extra inputs to a registry, so users need not be aware of such extra inputs.
In particular, this pull-request adds the
num_logits_to_keepinput to the registry.Models from huggingface/transformers that are exported using
torch.onnx.export, can have an extra input callednum_logits_to_keepthat should be default be set to0. Users should not need to know the input is required because it is an optimization in the torch model that does not impact the onnx model.Sometimes, the exporter will rename the input to
onnx::Neg_xyz. This pull-request also handles such scenarios.