Skip to content

Commit

Permalink
Update Node.js version from 18.x to 20.x in CI pipelines (#22576)
Browse files Browse the repository at this point in the history
  • Loading branch information
fs-eire authored Oct 24, 2024
1 parent a910ced commit ef7f1ce
Show file tree
Hide file tree
Showing 12 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion js/node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Refer to [ONNX Runtime JavaScript examples](https://github.com/microsoft/onnxrun

## Requirements

ONNXRuntime works on Node.js v16.x+ (recommend v18.x+) or Electron v15.x+ (recommend v28.x+).
ONNXRuntime works on Node.js v16.x+ (recommend v20.x+) or Electron v15.x+ (recommend v28.x+).

The following table lists the supported versions of ONNX Runtime Node.js binding provided with pre-built binaries.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ stages:
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

- task: onebranch.pipeline.tsaoptions@1
displayName: 'OneBranch TSAOptions'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:

- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'
force32bit: ${{ parameters.isX86 }}

# Our build machine doesn't have java x86
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
versionSpec: 3.11
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

- task: JavaToolInstaller@0
inputs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ stages:

- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

- script:
brew install coreutils ninja npm yarn
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'
- task: DownloadPipelineArtifact@2
inputs:
patterns: 'Release_*/**/*'
Expand Down
2 changes: 1 addition & 1 deletion tools/ci_build/github/azure-pipelines/templates/web-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ stages:
displayName: 'Checkout submodule onnx'
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'
- template: linux-web-init-and-check.yml
- task: Bash@3
displayName: 'Extract commit SHA and save to __commit.txt'
Expand Down
4 changes: 2 additions & 2 deletions tools/ci_build/github/azure-pipelines/templates/win-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ stages:
- task: NodeTool@0
condition: and(succeeded(), eq('${{ parameters.buildNodejs}}', true))
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

- ${{ if ne(parameters.CudaVersion, '') }}:
- template: jobs/download_win_gpu_library.yml
Expand Down Expand Up @@ -367,7 +367,7 @@ stages:
- task: NodeTool@0
condition: and(succeeded(), eq('${{ parameters.buildNodejs}}', true))
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

- ${{ if ne(parameters.CudaVersion, '') }}:
- template: jobs/download_win_gpu_library.yml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
architecture: $(buildArch)
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'
- template: download-deps.yml

- task: PythonScript@0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
displayName: 'Testing: force EOL to lf on windows for /js/**'
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'
- task: DownloadPipelineArtifact@2
inputs:
patterns: '${{ parameters.BuildConfig }}_*/**/*'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
displayName: 'Checkout submodule onnx'
- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'
- task: DownloadPipelineArtifact@2
inputs:
patterns: 'Release_*/**/*'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

- task: NodeTool@0
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

- task: NuGetToolInstaller@0
displayName: Use Nuget 6.10.x
Expand Down

0 comments on commit ef7f1ce

Please sign in to comment.