Skip to content

Commit

Permalink
Add comment to explain the 'TEMP'
Browse files Browse the repository at this point in the history
  • Loading branch information
skottmckay committed Sep 20, 2024
1 parent 45de1ee commit f7752c5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/onnxruntime/core/common/logging/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ using Timestamp = std::chrono::time_point<std::chrono::system_clock>;
// C++20 has operator<< in std::chrono for Timestamp type but mac builds need additional checks
// to ensure usage is valid.
// TODO: As we enable C++20 on other platforms we may need similar checks.

Check warning on line 63 in include/onnxruntime/core/common/logging/logging.h

View workflow job for this annotation

GitHub Actions / Optional Lint C++

[cpplint] reported by reviewdog 🐶 Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2] Raw Output: include/onnxruntime/core/common/logging/logging.h:63: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
// define a temporary value to determine whether to use the std::chrono or date implementation.
#define TEMP_USE_CXX20_STD_CHRONO __cplusplus >= 202002L

// Apply constraints for mac builds
Expand Down

0 comments on commit f7752c5

Please sign in to comment.