Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Support LSTM op #20293

Merged
merged 6 commits into from
Sep 27, 2024
Merged

[WebNN EP] Support LSTM op #20293

merged 6 commits into from
Sep 27, 2024

Conversation

shiyi9801
Copy link
Contributor

@shiyi9801 shiyi9801 commented Apr 12, 2024 •
edited
Loading

No description provided.

@shiyi9801
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Intel"

@shiyi9801
Copy link
Contributor Author

@Honry, @fdwr, @guschmue PTAL, thanks!

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@Honry
Copy link
Contributor

Honry commented Apr 18, 2024

@shiyi9801, pls. also update the https://github.com/microsoft/onnxruntime/blob/main/js/web/docs/webnn-operators.md.

@shiyi9801
Copy link
Contributor Author

@shiyi9801, pls. also update the https://github.com/microsoft/onnxruntime/blob/main/js/web/docs/webnn-operators.md.

@Honry Updated, please take a look, thanks :)

Honry
Honry approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@guschmue guschmue added the ep:WebNN WebNN execution provider label Apr 24, 2024
@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@shiyi9801 shiyi9801 force-pushed the webnn_lstm branch 2 times, most recently from 7dce2af to 58b713e Compare August 29, 2024 06:39
@fdwr
Copy link
Contributor

fdwr commented Aug 29, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Aug 29, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@fdwr
Copy link
Contributor

fdwr commented Aug 29, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

fdwr
fdwr previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, else LGTM.

onnxruntime/core/providers/webnn/builders/impl/lstm_op_builder.cc Show resolved Hide resolved
onnxruntime/core/providers/webnn/builders/impl/lstm_op_builder.cc Show resolved Hide resolved
@fdwr
Copy link
Contributor

fdwr commented Aug 29, 2024

/azp run Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Sep 13, 2024

New merge conflicts 🚧🚫.

@Honry
Copy link
Contributor

Honry commented Sep 13, 2024

@fdwr, @shiyi9801, how about hold this PR until the opSupportLimits is landed?

@shiyi9801
Copy link
Contributor Author

@fdwr, @shiyi9801, how about hold this PR until the opSupportLimits is landed?

agreed, will rebase after your PR is merged.

@fdwr
Copy link
Contributor

fdwr commented Sep 18, 2024

@fdwr, @shiyi9801, how about hold this PR until the opSupportLimits is landed?

That's complete now. 🏃‍♂️‍➡️

@shiyi9801 shiyi9801 force-pushed the webnn_lstm branch 3 times, most recently from 5082f7f to cb19d7b Compare September 18, 2024 07:05
@shiyi9801
Copy link
Contributor Author

@Honry @fdwr Rebased and fixed some bugs, please take another look, thanks!

fdwr
fdwr approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Sep 19, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Sep 19, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Sep 19, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Sep 19, 2024

Retrying CI which timed out.

@fdwr
Copy link
Contributor

fdwr commented Sep 19, 2024

/azp run Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Honry
Honry approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fdwr fdwr merged commit 1e3cd86 into microsoft:main Sep 27, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honry Honry Honry approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shiyi9801 @guschmue @Honry @fdwr