Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP, DONT REVIEW] add initializer to graph proto #22085

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

jslhcl
Copy link
Contributor

@jslhcl jslhcl commented Sep 13, 2024

Description

Motivation and Context

@chilo-ms
Copy link
Contributor

chilo-ms commented Sep 13, 2024

If we want to construct the model proto via manipulating the graph proto directly, and then serialize model proto to string/array for (1) onnx-tensorrt parser to consume and (2) ORT TRT to deserialize it when calling OrtGraph_DeserializeFromArray to get the ORT graph.

Then it's not binary compatible (you already mentioned before) is the concern.

The reason is EP shared lib might use one version of protobuf to serialize the model proto to array/string, and ORT uses another version of protobuf to deserialize it. And we know that proto serialization is not stable per doc.

But we can probably do what Adrian previously mentioned that ORT provides an API to tell EP developer which protobuf version it uses to make sure EP share lib can link against the same protobuf lib.

@jslhcl jslhcl changed the title add initializer to graph proto [WIP, DONT REVIEW] add initializer to graph proto Sep 18, 2024
@jslhcl jslhcl marked this pull request as ready for review September 18, 2024 23:26
@jslhcl jslhcl merged commit 76a9305 into leca/outOfTreeEP Sep 18, 2024
30 of 39 checks passed
@jslhcl jslhcl deleted the leca/outTreeDraft branch September 18, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants