Update gradle version to 8.7 #22206
Update gradle version to 8.7 #22206
Conversation
java/gradlew.bat
Outdated
There was a problem hiding this comment.
Changes from this file is generated by ./gradlew wrapper --gradle-version=8.10.2 --distribution-type=bin
|
All changes from Changes from |
jchen351
changed the title
| @@ -13,7 +13,7 @@ | |||
| #Tue Jan 26 17:36:02 PST 2021 | |||
| android.enableJetifier=true | |||
| android.useAndroidX=true | |||
| OnnxruntimeModule_buildToolsVersion=29.0.2 | |||
| OnnxruntimeModule_buildToolsVersion=30.0.3 | |||
There was a problem hiding this comment.
So should we specify the 34+ build tools here if it's going to be forced to that anyway?
There was a problem hiding this comment.
For this MR, I am only updating the 'com.android.tools.build:gradle:7.4.2' insead of the 'com.android.tools.build:gradle:8.5'. So, the required build tool version is only 30.0.3.
There was a problem hiding this comment.
In a separated PR when the com.android.tools.build:gradle is 8.5+ the required version of Android SDK Build Tools then become 34.0.0
tools/ci_build/github/azure-pipelines/templates/android-java-api-aar.yml
Outdated
Show resolved
Hide resolved
| @@ -95,7 +95,7 @@ stages: | |||
| --android_sdk_path $ANDROID_HOME \ | |||
| --android_ndk_path $ANDROID_NDK_HOME \ | |||
| --android_abi=x86_64 \ | |||
| --android_api=30 \ | |||
| --android_api=33 \ | |||
There was a problem hiding this comment.
Due to Application crashed during Run React Native Detox Android e2e Tests child-process:SPAWN_STDOUT INSTRUMENTATION_RESULT: shortMsg=Process crashed.
After searching the on stack overflow we need to update andriod 33+ for newer com.android.tools.build:gradle.
Besides some places already used android 34.
I might need to down grade that to 33, or upgrade everything lese to 34 as well.
…-size-check-stage.yml and switching min sdk version back to 21
"android_target_sdk_version": 33,
DEFAULT_ANDROID_TARGET_SDK_VER = 33
// implementation "com.microsoft.onnxruntime:onnxruntime-android:latest.integration@aar"
….integration@aar" revert back to
…#22771) ### Description This change is to update the Gradle version within java project to 8.7, it also upgrades the JAVA to 17. Gradle version from react-native was also updated to 7.5 to make it compatible with changes from the Java directory. However, the target java version remains the same. Java version from these will be upgraded in a separated PR. This is spited from #22206 ### Motivation and Context This is the first step to upgrade the react native version.
# Conflicts: # java/build-android.gradle # java/src/test/android/app/build.gradle # java/src/test/android/app/src/main/AndroidManifest.xml # js/react_native/android/gradle.properties # js/react_native/android/gradle/wrapper/gradle-wrapper.jar # js/react_native/android/gradle/wrapper/gradle-wrapper.properties # js/react_native/android/gradlew # js/react_native/android/gradlew.bat # tools/ci_build/github/android/build_aar_package.py # tools/ci_build/github/android/default_full_aar_build_settings.json
# Conflicts: # js/react_native/android/gradle.properties # js/react_native/e2e/android/build.gradle # js/react_native/e2e/android/gradle/wrapper/gradle-wrapper.properties # tools/ci_build/github/android/training_full_aar_build_settings.json # tools/ci_build/github/js/react_native_e2e_full_aar_build_settings.json
# Conflicts: # js/react_native/e2e/android/gradle.properties
Description
Update the gradle version from andriod projects to 8.7
And Android gradle build tool to version 7.4.2 across all of the ORT project.
Motivation and Context
Current versions of gradle are inconsistent and outdated to support newer version of plugins such as react-native.
Inconsistent versioning makes upgrading a lot more challenging.
Current issue
child-process:SPAWN_STDOUT INSTRUMENTATION_RESULT: shortMsg=Process crashed.<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>latest.integrationdoes work on "com.microsoft.onnxruntime:onnxruntime-android:latest.integration@aar" anymoreAB#50089