[DML] Add support for AppendExecutionProvider_DML1 with C#. #22291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
previously approved these changes
Nov 13, 2024
yuslepukhin
requested changes
Nov 13, 2024
Comment on lines
2126
to
2128
| uint /*(uint32_t)*/ version, | ||
| out IntPtr /* const OrtMemoryInfo** */ provider_api); | ||
|
|
There was a problem hiding this comment.
Generally we require (although this was not enforced in the past) lines to be of 120 chars or less.
And, yes, we use default C# formating.
| /// </summary> | ||
| /// <param name="dmlDevice">A IDMLDevice reference</param> | ||
| /// <param name="commandQueue">A ID3D12CommandQueue reference</param> | ||
| public void AppendExecutionProvider_DML1(IntPtr dmlDevice, IntPtr commandQueue) |
There was a problem hiding this comment.
Generally, we do not expose native IntPtr handles via public API. The preferred way is to expose an object of DmlDevice that has a handle.
That object is likely to be IDisposable.
Then that object can expose an internal property Handle that can be used for NativeApi.
The same probably goes for commandQueue.
Co-authored-by: Dwayne Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to use the SessionOptionsAppendExecutionProvider_DML1 method with C#.
Motivation and Context
It was not possible to use the SessionOptionsAppendExecutionProvider_DML1 method with C# before. This PR adds adds the mapping of the DML EP, only for the SessionOptionsAppendExecutionProvider_DML1 method. The user of the library is still required to create the IDMLDevice and ID3D12CommandQueue manually, however that may be.
We validated that this works BY using CsWin32 to create projections of the native types and copying the logic from the ESRGAN super-resolution model sample, in particular, the SelectAdapter and CreateDmlDeviceAndCommandQueue methods from the helpers.cpp class.
A follow-up PR could make this process even simpler and provide this helper method, but it seemed a little bit too much for the basic support.