Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a tiny problem in winml.cmake #23173

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix a tiny problem in winml.cmake #23173

merged 1 commit into from
Dec 20, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Dec 20, 2024

Description

CMake's target_link_libraries function accepts plain library name(like re2) or target name(like re2::re2) or some other kinds of names. "plain library names" are old-fashioned, for compatibility only. We should use target names.

Motivation and Context

To make vcpkg work with winml build. See #23158

@snnn snnn mentioned this pull request Dec 20, 2024
13 tasks
@snnn snnn merged commit fcc34da into main Dec 20, 2024
92 of 96 checks passed
@snnn snnn deleted the snnn/fix_winml_dll branch December 20, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants