Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors instantiating symbol checksum algorithm. #1239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beteitle
Copy link

@beteitle beteitle commented Aug 5, 2020

Ignore errors instantiating source checksum method during symbol source lookup. For many use cases, source checksum is a "nice to have", but not a requirement. Cryptography method instantiation may fail in certain cases. For example, if FipsAlgorithmPolicy is in place on your host machine, you are not allowed to instantiate MD5. Failing to checksum should not prevent source lookup workflow in my opinion (seems to work fine without it being performed for well behaving source server).

… not need the checksum, so it doesn't make sense to crash. Some checksum methods will fail when FipsAlgorithmPolicy is enabled on your machine.
@ghost
Copy link

ghost commented Aug 5, 2020

CLA assistant check
All CLA requirements met.

@brianrob
Copy link
Member

@beteitle, thanks for your contribution. In general, I want to keep these kinds of safeguards by default. Not having them can result in invalid/incorrect data in some cases. If you're running into cases where where the algorithms can't be executed, one option would be to have a flag, similiar to /UnsafePDBMatch where you can opt-out of these safety checks. I would be supportive of this.

Base automatically changed from master to main February 2, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants