Fix for issue #1767 #1869
Open
Fix for issue #1767 #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates GetActiveSessionNames to check for ERROR_MORE_DATA and retry once when calling QueryAllTraces. I chose to implement this by modifying the current function as little as possible. To do that, I wrapped the core logic and made a recursive call to it for the retry, with a depth counter that maxes out at 1. This change also has a unit test, but I don't think it is ready to be comitted. I am including it so a discussion can be had. In general it seems hard to reliably simulate this condition on a broad set of machines that will run this test suite (65+ active etw sessions while EtwMaxLoggers registry key is not set.)
brianrob
reviewed
May 25, 2023
There was a problem hiding this comment.
@ryandle, thank you for contributing this, and sorry for the delay in reviewing it. Overall, the change to TraceEventSession looks good to me. I did make a change in this space that is conflicting with your change - can you please update your code to consume the change that allocates propertiesArray on the heap?
As far as the unit test goes, I think you are going to have trouble getting this to work almost everywhere. The only real option I see is to mock it. I would say that at this point, you can just remove the unit test, but it is important to make sure that this actually works in practice. Have you seen this work on machine that does have this many sessions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates GetActiveSessionNames to check for ERROR_MORE_DATA and retry once when calling QueryAllTraces.
I chose to implement this by modifying the current function as little as possible. To do that, I wrapped the core logic and made a recursive call to it for the retry, with a depth counter that maxes out at 1.
This change also has a unit test, but I don't think it is ready to be committed. I am including it so a discussion can be had about it.
In general it seems hard to reliably simulate this condition on a broad set of machines that will run this test suite (65+ active etw sessions while EtwMaxLoggers registry key is not set.) Just between my two developer machines I couldn't do it 🤣
I'm open to ideas here on how the test can be improved to be more reliable, otherwise it probably needs to be removed.