Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes to deploy to allow for az cli login deployment #287

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Small changes to deploy to allow for az cli login deployment #287

wants to merge 3 commits into from

Conversation

lossyrob
Copy link
Contributor

Changes to the deployment scripts and environment to better enable a workflow that uses the az cli identity for deploying:

  • Don't az login if already logged in
  • Use azcli kubeconvert if no SP is defined
  • Don't require client id/secret in environment

Also, avoid terraform from manipulating manual security rules on the NSG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lossyrob @TomAugspurger