Skip to content

Commit

Permalink
feat(roll): roll to ToT Playwright (06-09-23)
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] committed Sep 6, 2023
1 parent ec2ff0c commit 0cf4961
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
2 changes: 0 additions & 2 deletions nodejs/docs/chrome-extensions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ const pathToExtension = path.join(__dirname, 'my-extension');
const context = await chromium.launchPersistentContext('', {
headless: false,
args: [
// the new headless arg for chrome v109+. Use '--headless=chrome'
// as arg for browsers v94-108.
`--headless=new`,
`--disable-extensions-except=${pathToExtension}`,
`--load-extension=${pathToExtension}`,
Expand Down
4 changes: 2 additions & 2 deletions nodejs/docs/test-typescript.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ Using dynamic imports inside a function passed to various `evaluate()` methods i
To work around this issue, use a string template instead of a function:

```js
await page.evaluate(`async () => {
await page.evaluate(`(async () => {
const { value } = await import('some-module');
console.log(value);
}`);
})()`);
```


Expand Down
2 changes: 1 addition & 1 deletion python/docs/chrome-extensions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ context = playwright.chromium.launch_persistent_context(
"",
headless=False,
args=[
"--headless=new", # the new headless arg for chrome v109+. Use '--headless=chrome' as arg for browsers v94-108.
"--headless=new",
f"--disable-extensions-except={path_to_extension}",
f"--load-extension={path_to_extension}",
],
Expand Down
4 changes: 2 additions & 2 deletions python/docs/evaluating.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ Wrong:
```py
data = { 'text': 'some data', 'value': 1 }
result = page.evaluate("""() => {
# There is no |data| in the web page.
// There is no |data| in the web page.
window.myApp.use(data)
}""")
```
Expand All @@ -231,7 +231,7 @@ result = page.evaluate("""() => {
```py
data = { 'text': 'some data', 'value': 1 }
result = await page.evaluate("""() => {
# There is no |data| in the web page.
// There is no |data| in the web page.
window.myApp.use(data)
}""")
```
Expand Down

0 comments on commit 0cf4961

Please sign in to comment.