Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roll): roll to ToT Playwright (roll/next-27-09-24) #1537

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dotnet/docs/api/class-page.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -2442,7 +2442,11 @@ await page.GotoAsync("https://www.microsoft.com");

**Arguments**
- `width` [int] <font size="2">Added in: v1.10</font><a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="page-set-viewport-size-option-width"/><a href="#page-set-viewport-size-option-width" class="list-anchor">#</a>

Page width in pixels.
- `height` [int] <font size="2">Added in: v1.10</font><a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="page-set-viewport-size-option-height"/><a href="#page-set-viewport-size-option-height" class="list-anchor">#</a>

Page height in pixels.

**Returns**
- [void]<a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="page-set-viewport-size-return"/><a href="#page-set-viewport-size-return" class="list-anchor">#</a>
Expand Down
4 changes: 4 additions & 0 deletions java/docs/api/class-page.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -1965,7 +1965,11 @@ page.navigate("https://example.com");

**Arguments**
- `width` [int] <font size="2">Added in: v1.10</font><a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="page-set-viewport-size-option-width"/><a href="#page-set-viewport-size-option-width" class="list-anchor">#</a>

Page width in pixels.
- `height` [int] <font size="2">Added in: v1.10</font><a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="page-set-viewport-size-option-height"/><a href="#page-set-viewport-size-option-height" class="list-anchor">#</a>

Page height in pixels.

**Returns**
- [void]<a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="page-set-viewport-size-return"/><a href="#page-set-viewport-size-return" class="list-anchor">#</a>
Expand Down
2 changes: 2 additions & 0 deletions nodejs/docs/api/class-androiddevice.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,8 @@ await androidDevice.open(command);

**Arguments**
- `command` [string]<a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="android-device-open-option-command"/><a href="#android-device-open-option-command" class="list-anchor">#</a>

Shell command to execute.

**Returns**
- [Promise]&lt;[AndroidSocket]&gt;<a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="android-device-open-return"/><a href="#android-device-open-return" class="list-anchor">#</a>
Expand Down
2 changes: 2 additions & 0 deletions nodejs/docs/api/class-test.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -1325,6 +1325,8 @@ test('test', async ({ page }) => {

Whether to box the step in the report. Defaults to `false`. When the step is boxed, errors thrown from the step internals point to the step call site. See below for more details.
- `location` [Location] *(optional)* <font size="2">Added in: v1.48</font><a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="test-step-option-location"/><a href="#test-step-option-location" class="list-anchor">#</a>

Specifies a custom location for the step to be shown in test reports and trace viewer. By default, location of the [test.step()](/api/class-test.mdx#test-step) call is shown.

**Returns**
- [Promise]&lt;[Object]&gt;<a aria-hidden="true" tabIndex="-1" class="list-anchor-link" id="test-step-return"/><a href="#test-step-return" class="list-anchor">#</a>
Expand Down
5 changes: 4 additions & 1 deletion nodejs/docs/api/class-testinfo.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,10 @@ testInfo.status

Tags that apply to the test. Learn more about [tags](../test-annotations.mdx#tag-tests).

Note that any changes made to this list while the test is running will not be visible to test reporters.
:::note

Any changes made to this list while the test is running will not be visible to test reporters.
:::

**Usage**

Expand Down
9 changes: 6 additions & 3 deletions src/api_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class ApiParser {
if (!name)
throw new Error('Invalid member name ' + spec.text);
if (match[1] === 'param') {
const arg = this.parseProperty(spec);
const arg = this.parseProperty(spec, match[2]);
if (!arg)
return;
arg.name = name;
Expand All @@ -182,7 +182,7 @@ class ApiParser {
}
} else {
// match[1] === 'option'
const p = this.parseProperty(spec);
const p = this.parseProperty(spec, match[2]);
if (!p)
return;
let options = method.argsArray.find(o => o.name === 'options');
Expand All @@ -198,11 +198,14 @@ class ApiParser {

/**
* @param {MarkdownHeaderNode} spec
* @param {string} memberName
* @returns {docs.Member | null}
*/
parseProperty(spec) {
parseProperty(spec, memberName) {
const param = childrenWithoutProperties(spec)[0];
const text = /** @type {string}*/(param.text);
if (text.substring(text.lastIndexOf('>') + 1).trim())
throw new Error(`Extra information after type while processing "${memberName}".\nYou probably need an extra empty line before the description.\n================\n${text}`);
let typeStart = text.indexOf('<');
while ('?e'.includes(text[typeStart - 1]))
typeStart--;
Expand Down
Loading