Skip to content

Commit

Permalink
docs(ci): recommend noble instead of jammy (#32923)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt authored Oct 2, 2024
1 parent dbf7976 commit 67c37cf
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions docs/src/ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v%%VERSION%%-jammy
image: mcr.microsoft.com/playwright:v%%VERSION%%-noble
options: --user 1001
steps:
- uses: actions/checkout@v4
Expand All @@ -233,7 +233,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright/python:v%%VERSION%%-jammy
image: mcr.microsoft.com/playwright/python:v%%VERSION%%-noble
options: --user 1001
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright/java:v%%VERSION%%-jammy
image: mcr.microsoft.com/playwright/java:v%%VERSION%%-noble
options: --user 1001
steps:
- uses: actions/checkout@v4
Expand All @@ -288,7 +288,7 @@ jobs:
name: 'Playwright Tests'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright/dotnet:v%%VERSION%%-jammy
image: mcr.microsoft.com/playwright/dotnet:v%%VERSION%%-noble
options: --user 1001
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -415,7 +415,7 @@ Large test suites can take very long to execute. By executing a preliminary test
This will give you a faster feedback loop and slightly lower CI consumption while working on Pull Requests.
To detect test files affected by your changeset, `--only-changed` analyses your suites' dependency graph. This is a heuristic and might miss tests, so it's important that you always run the full test suite after the preliminary test run.
```yml js title=".github/workflows/playwright.yml" {20-23}
```yml js title=".github/workflows/playwright.yml"
name: Playwright Tests
on:
push:
Expand Down Expand Up @@ -766,28 +766,28 @@ Running Playwright on CircleCI is very similar to running on GitHub Actions. In
```yml js
executors:
pw-jammy-development:
pw-noble-development:
docker:
- image: mcr.microsoft.com/playwright:v%%VERSION%%-noble
```
```yml python
executors:
pw-jammy-development:
pw-noble-development:
docker:
- image: mcr.microsoft.com/playwright/python:v%%VERSION%%-noble
```
```yml java
executors:
pw-jammy-development:
pw-noble-development:
docker:
- image: mcr.microsoft.com/playwright/java:v%%VERSION%%-noble
```
```yml csharp
executors:
pw-jammy-development:
pw-noble-development:
docker:
- image: mcr.microsoft.com/playwright/dotnet:v%%VERSION%%-noble
```
Expand All @@ -801,7 +801,7 @@ Sharding in CircleCI is indexed with 0 which means that you will need to overrid
```yml
playwright-job-name:
executor: pw-jammy-development
executor: pw-noble-development
parallelism: 4
steps:
- run: SHARD="$((${CIRCLE_NODE_INDEX}+1))"; npx playwright test -- --shard=${SHARD}/${CIRCLE_NODE_TOTAL}
Expand Down Expand Up @@ -997,7 +997,7 @@ type: docker
steps:
- name: test
image: mcr.microsoft.com/playwright:v%%VERSION%%-jammy
image: mcr.microsoft.com/playwright:v%%VERSION%%-noble
commands:
- npx playwright test
```
Expand Down

0 comments on commit 67c37cf

Please sign in to comment.