Skip to content

Commit

Permalink
feat(webkit): roll to r2092 (#33078)
Browse files Browse the repository at this point in the history
  • Loading branch information
playwrightmachine authored Oct 14, 2024
1 parent a8df750 commit c7fbedd
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/playwright-core/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
{
"name": "webkit",
"revision": "2091",
"revision": "2092",
"installByDefault": true,
"revisionOverrides": {
"mac10.14": "1446",
Expand Down
4 changes: 2 additions & 2 deletions tests/library/modernizr.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ it('Safari Desktop', async ({ browser, browserName, platform, server, headless }
expected.publickeycredential = false;
expected.mediastream = false;
if (headless)
expected.todataurljpeg = false;
expected.todataurlwebp = true;

// GHA
delete actual.variablefonts;
Expand Down Expand Up @@ -124,7 +124,7 @@ it('Mobile Safari', async ({ playwright, browser, browserName, platform, server,
expected.publickeycredential = false;
expected.mediastream = false;
if (headless)
expected.todataurljpeg = false;
expected.todataurlwebp = true;

// GHA
delete actual.variablefonts;
Expand Down
5 changes: 3 additions & 2 deletions tests/page/page-screenshot.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,13 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('screenshot-clip-odd-size.png');
});

it('should work for canvas', async ({ page, server, isElectron, isMac, macVersion, browserName, headless }) => {
it('should work for canvas', async ({ page, server, isElectron, isMac, isLinux, macVersion, browserName, headless }) => {
it.fixme(isElectron && isMac, 'Fails on the bots');
await page.setViewportSize({ width: 500, height: 500 });
await page.goto(server.PREFIX + '/screenshots/canvas.html');
const screenshot = await page.screenshot();
if (!headless && browserName === 'chromium' && isMac && os.arch() === 'arm64' && macVersion >= 14)
if ((!headless && browserName === 'chromium' && isMac && os.arch() === 'arm64' && macVersion >= 14) ||
(browserName === 'webkit' && isLinux))
expect(screenshot).toMatchSnapshot('screenshot-canvas-with-accurate-corners.png');
else
expect(screenshot).toMatchSnapshot('screenshot-canvas.png');
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit c7fbedd

Please sign in to comment.