Skip to content

Commit

Permalink
fix(har timing): record connect timing for proxied connections (#32855
Browse files Browse the repository at this point in the history
)

Fixes a bug discovered in
#32647. When using http
proxy, the `connect` event isn't emitted so we don't populate
`tcpConnectionAt`. The updated version of `https-proxy-agent` emits a
`proxyConnect` as a replacement, so this PR updates and listens to that
event.
For socks proxies, the `on("socket")` event is emitted once the SOCKS
connection is established, which is the equivalent of having a TCP
connection available.

---------

Signed-off-by: Simon Knott <[email protected]>
Co-authored-by: Max Schmitt <[email protected]>
  • Loading branch information
Skn0tt and mxschmitt authored Oct 7, 2024
1 parent ddeabdf commit de4a4d1
Show file tree
Hide file tree
Showing 7 changed files with 94 additions and 432 deletions.
Loading

0 comments on commit de4a4d1

Please sign in to comment.