fix(har): account for reused sockets #33087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Oct 14, 2024
| tcpConnectionAt ??= happyEyeBallsTimings.tcpConnectionAt; | ||
| if (request.reusedSocket) { | ||
| reusedSocketAt = monotonicTime(); | ||
| dnsLookupAt = startAt; |
There was a problem hiding this comment.
Perhaps set both dnsLookupAt and tcpConnectionAt to undefined? Would that make the code cleaner?
There was a problem hiding this comment.
Good idea. I've refactored it a little more, how do you like that?
Test results for "tests 1"1 flaky35870 passed, 620 skipped Merge workflow run. |
dgozman
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32960
If the socket is reused, the connect and DNS timings are set to -1, because that timing doesn't apply to the current request. The time between request start and the socket being free is counted as
blocked.