Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trace viewer): render hint for canvas in snapshots #33092

Closed
wants to merge 1 commit into from
Closed

feat(trace viewer): render hint for canvas in snapshots #33092

wants to merge 1 commit into from

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Oct 14, 2024

Part of #32847

Screenshot 2024-10-14 at 14 42 33

Unsure what's the best way of testing this. Should we add a snapshot test for it?

@Skn0tt Skn0tt requested a review from dgozman October 14, 2024 12:52
@Skn0tt Skn0tt self-assigned this Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

1 flaky ⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

35863 passed, 620 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt mentioned this pull request Oct 15, 2024
Open
4 tasks
dgozman
dgozman approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI feedback:

  • I'd move the warning sign a bit higher up to make it visually centered.
  • For larger canvases, having the explanation text right there instead of in a title could be very helpful.

@Skn0tt
Copy link
Member Author

Skn0tt commented Oct 18, 2024

closing in favour of #33119

@Skn0tt Skn0tt closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skn0tt @dgozman