fix(trace viewer): Screenshot click target placement #33114
Closed
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes the last element of #32847, so it reverts the changes where we hide the toggle.
Misplacement before:
Screen.Recording.2024-10-15.at.11.38.02.mov
Correct placement after:
Screen.Recording.2024-10-15.at.11.36.59.mov
The bug was two-fold.
position: fixed
, we need to take the<BrowserFrame />
's height into account.margin: -10px 0 0 -10px
was relying on a 20px width that wasn't perfect.transform
works better, learned that through https://css-tricks.com/quick-css-trick-how-to-center-an-object-exactly-in-the-center/.Closes #32847