Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): clip
canvas
contents from screenshots #33119base: main
Are you sure you want to change the base?
feat(tracing): clip
canvas
contents from screenshots #33119Changes from 12 commits
79a5407
6d0f0be
e19f0ee
8687e55
82ad4ec
b3bd73b
8c35ade
bf5f718
23822dc
c70f372
ccdfeee
3389fdd
45d1b54
2dfa90f
309bea0
5aae14e
455be13
ea4116e
5d4d73d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's skip both
drawWarningBackground
anddrawImage
calls in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made it skip
drawImage
, but I don't think we should skipdrawCheckerboard
- having that around is still valuable to show that there's something missing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also made it skip
drawCheckerboard
to align with what we discussed in the meeting. Gonna potentially change that in a follow-up. ea4116eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I predict this will be flaky 😄 We usually do a few rafs in the hopes it will redraw, but even that does not always help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a raf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's
requestAnimationFrame
! See https://github.com/Skn0tt/playwright/blob/ea4116e64546dca6b41160c50a42c69e86cc3fcd/tests/page/pageTest.ts#L39.