Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ff test for codegen #33122

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

pavelfeldman
Copy link
Member

No description provided.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any insight on why it was slow?

@pavelfeldman pavelfeldman merged commit 23b1012 into microsoft:main Oct 15, 2024
28 of 29 checks passed
@mxschmitt
Copy link
Member

Investigation: recorderPage.getByRole('button', { name: 'Record' }).click(); is retrying an infinite amount of time because page.pause() disables the test timeout. This stalls everything and globalTimeout kicks in.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-library] › library/inspector/pause.spec.ts:485:5 › pause › should record from debugger @firefox-ubuntu-22.04-node18

5 flaky ⚠️ [chromium] › components/splitView.spec.tsx:35:5 › should render sidebar first @web-components-web
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:42:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:53:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:64:14 › page screenshot › should work with a mobile viewport and fullPage @webkit-ubuntu-22.04-node18

35950 passed, 624 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants