-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement tree w/o list #33169
Conversation
b2659db
to
9f9cc03
Compare
This comment has been minimized.
This comment has been minimized.
tests/page/page-check.spec.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this file
} | ||
|
||
const element = itemListRef.current?.children.item(newIndex); | ||
scrollIntoViewIfNeeded(element || undefined); | ||
// scrollIntoViewIfNeeded(element || undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code?
expanded, | ||
parent: rootItem === parent ? null : parent, | ||
next: null, | ||
prev: lastItem, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe go to the parent's prev if this is the first child?
9f9cc03
to
2c8beb5
Compare
This comment has been minimized.
This comment has been minimized.
2c8beb5
to
45b9687
Compare
Test results for "tests 1"36399 passed, 639 skipped Merge workflow run. |
No description provided.