Merging beta into main (#38)

* Calendar Test Added - gitignore updated * Removed Shimmer Coverage/ Updated Test Snaps * Udpated Test for Progress Indicator * fix:(Calendar) test failing due to dependency on today's date (#30) * fix: (pivot) width in custom pages (#33) chore: (pivot) npm update - stay with pcf-scripts 1.14.2 due to webpack dependency issue * fix: auto-height in custom pages (#32) fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase * Facepile component added (#35) * Facepile component added * reactdom-definition * fixing typos * Update Facepile.1033.resx Adding preview tag Co-authored-by: Scott Durow <[email protected]>
microsoft · Sep 30, 2022 · c0e65ed · c0e65ed
1 parent 9841c04
commit c0e65ed
Show file tree

Hide file tree

Showing 50 changed files with 27,799 additions and 5,471 deletions.
diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
@@ -41,6 +41,7 @@ jobs:
                 `${process.env.GITHUB_WORKSPACE}/ContextMenu/ContextMenu`,
                 `${process.env.GITHUB_WORKSPACE}/DetailsList/DetailsList`,
                 `${process.env.GITHUB_WORKSPACE}/Elevation/Elevation`,
+                `${process.env.GITHUB_WORKSPACE}/Facepile/Facepile`,
                 `${process.env.GITHUB_WORKSPACE}/Icon/Icon`,
                 `${process.env.GITHUB_WORKSPACE}/KeyboardShortcuts/KeyboardShortcuts`,
                 `${process.env.GITHUB_WORKSPACE}/Nav/Nav`,
@@ -71,6 +72,8 @@ jobs:
         working-directory: "./DetailsList"
       - run: npm ci
         working-directory: "./Elevation"
+      - run: npm ci
+        working-directory: "./Facepile"
       - run: npm ci
         working-directory: "./Icon"
       - run: npm ci

diff --git a/.github/workflows/pr_validate_all.yml b/.github/workflows/pr_validate_all.yml
@@ -19,6 +19,7 @@ jobs:
          - "./ContextMenu"
          - "./DetailsList"
          - "./Elevation"
+         - "./Facepile"
          - "./Icon"
          - "./KeyboardShortcuts"
          - "./Nav"

diff --git a/Calendar/.vscode/launch.json b/Calendar/.vscode/launch.json
@@ -0,0 +1,20 @@
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "type": "node",
+      "name": "vscode-jest-tests",
+      "request": "launch",
+      "args": ["${fileBasename}", "--runInBand", "--code-coverage=false" ],
+      "cwd": "${workspaceFolder}",
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen",
+      "smartStep": true,
+      "program": "${workspaceFolder}/node_modules/jest/bin/jest",
+      "skipFiles": ["node_modules/**/*.js", "<node_internals>/**/*.js", "async_hooks.js", "inspector_async_hook.js"]
+    }
+  ]
+}
diff --git a/Calendar/.vscode/settings.json b/Calendar/.vscode/settings.json
@@ -0,0 +1,2 @@
+{
+}
diff --git a/Calendar/config/tests.js b/Calendar/config/tests.js
@@ -7,5 +7,8 @@ const Adapter = require('enzyme-adapter-react-16');
 // Initialize icons.
 initializeIcons(undefined, { disableWarnings: true });
 
+// Ensure the test snapshots are consistent when using today's date
+jest.useFakeTimers('modern').setSystemTime(new Date(2022, 8, 1, 12, 0, 0));
+
 // Configure enzyme.
 configure({ adapter: new Adapter() });
diff --git a/Facepile/.eslintrc.json b/Facepile/.eslintrc.json
@@ -0,0 +1,55 @@
+{
+  "env": {
+      "browser": true,
+      "es2021": true
+  },
+  "extends": [
+      "eslint:recommended",
+      "plugin:react/recommended",
+      "plugin:react-hooks/recommended",
+      "plugin:@typescript-eslint/recommended",
+      "plugin:prettier/recommended",
+      "prettier",
+      "plugin:sonarjs/recommended"
+  ],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+      "ecmaFeatures": {
+          "jsx": true
+      },
+      "ecmaVersion": 12,
+      "sourceType": "module"
+  },
+  "plugins": [
+      "react",
+      "react-hooks",
+      "@typescript-eslint",
+      "prettier",
+      "sonarjs"
+  ],
+  "settings": {
+      "react": {
+        "pragma": "React",
+        "version": "detect"
+      }
+    },
+  "ignorePatterns": ["**/generated/*.ts"],
+  "rules": {
+      "eqeqeq": [2, "smart"],
+      "prettier/prettier": "error",
+      "arrow-body-style": "off",
+      "prefer-arrow-callback": "off",
+      "linebreak-style": [
+          "error",
+          "windows"
+      ],
+      "quotes": [
+          "error",
+          "single"
+      ],
+      "semi": [
+          "error",
+          "always"
+      ]
+  }
+}
diff --git a/Facepile/.gitignore b/Facepile/.gitignore
@@ -0,0 +1,17 @@
+# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.
+
+# dependencies
+/node_modules
+
+# generated directory
+**/generated
+
+# output directory
+/out
+
+#coverage directory
+/coverage
+
+# msbuild output directories
+/bin
+/obj
diff --git a/Facepile/.prettierrc.json b/Facepile/.prettierrc.json
@@ -0,0 +1,8 @@
+{
+    "semi": true,
+    "trailingComma": "all",
+    "singleQuote": true,
+    "printWidth": 120,
+    "tabWidth": 4,
+    "endOfLine":"auto"    
+  }
diff --git a/Facepile/Facepile.pcfproj b/Facepile/Facepile.pcfproj
@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup>
+    <PowerAppsTargetsPath>$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\PowerApps</PowerAppsTargetsPath>
+  </PropertyGroup>
+
+  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" />
+  <Import Project="$(PowerAppsTargetsPath)\Microsoft.PowerApps.VisualStudio.Pcf.props" Condition="Exists('$(PowerAppsTargetsPath)\Microsoft.PowerApps.VisualStudio.Pcf.props')" />
+
+  <PropertyGroup>
+    <Name>Facepile</Name>
+    <ProjectGuid>eb11ae1f-1080-4a88-84d3-3367b8155c39</ProjectGuid>
+    <OutputPath>$(MSBuildThisFileDirectory)out\controls</OutputPath>
+    <PcfBuildMode>production</PcfBuildMode>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <TargetFrameworkVersion>v4.6.2</TargetFrameworkVersion>
+    <!--Remove TargetFramework when this is available in 16.1-->
+    <TargetFramework>net462</TargetFramework>
+    <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.PowerApps.MSBuild.Pcf" Version="1.*" />
+    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\.gitignore" />
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\bin\**" />
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\obj\**" />
+    <ExcludeDirectories Include="$(OutputPath)\**" />
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\*.pcfproj" />
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\*.pcfproj.user" />
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\*.sln" />
+    <ExcludeDirectories Include="$(MSBuildThisFileDirectory)\node_modules\**" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <None Include="$(MSBuildThisFileDirectory)\**" Exclude="@(ExcludeDirectories)" />
+  </ItemGroup>
+
+  <Import Project="$(MSBuildToolsPath)\Microsoft.Common.targets" />
+  <Import Project="$(PowerAppsTargetsPath)\Microsoft.PowerApps.VisualStudio.Pcf.targets" Condition="Exists('$(PowerAppsTargetsPath)\Microsoft.PowerApps.VisualStudio.Pcf.targets')" />
+
+</Project>
diff --git a/Facepile/Facepile/ContextExtended.ts b/Facepile/Facepile/ContextExtended.ts
@@ -0,0 +1,8 @@
+// This is undocumented - but needed since canvas apps sets non-zero tabindexes
+// so we must use the tabindex provided by the context for accessibility purposes
+export interface ContextEx {
+    accessibility: {
+        assignedTabIndex: number;
+        assignedTooltip?: string;
+    };
+}
diff --git a/Facepile/Facepile/ControlManifest.Input.xml b/Facepile/Facepile/ControlManifest.Input.xml
@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest>
+  <control namespace="PowerCAT" constructor="Facepile" version="0.0.1" display-name-key="Facepile" description-key="Facepile_Desc" control-type="virtual">
+    <property name="AccessibilityLabel" display-name-key="AccessibilityLabel" of-type="SingleLine.Text" usage="input" required="false" />
+    <property name="Theme" display-name-key="Theme" of-type="Multiple" usage="input" required="false" />
+    <!-- Input Property -->
+    <property name="MaxDisplayablePersonas" display-name-key="MaxDisplayablePersonas" of-type="Whole.None" default-value="5" usage="input" />
+    <property name="ImageShouldFadeIn" display-name-key="ImageShouldFadeIn" of-type="TwoOptions" usage="input" />
+    <property name="ShowAddButton" display-name-key="ShowAddButton" of-type="TwoOptions" usage="input" />
+    <property name="OverflowButtonAriaLabel" display-name-key="OverflowButtonAriaLabel" of-type="SingleLine.Text" default-value="More users" usage="input" required="false" />
+    <property name="AddbuttonAriaLabel" display-name-key="AddbuttonAriaLabel" of-type="SingleLine.Text" default-value="Add a new person to the Facepile" usage="input" required="false" />
+
+    <!-- Output Property -->
+    <property name="EventName" display-name-key="EventName" of-type="SingleLine.Text" usage="output" />
+    <property name="PersonaSize" display-name-key="PersonaSize" description-key="PersonaSize" usage="input" of-type="Enum" required="false">
+      <value name="Size8" display-name-key="Size8" description-key="Size8">Size8</value>
+      <value name="Size24" display-name-key="Size24" description-key="Size24">Size24</value>
+      <value name="Size32" display-name-key="Size32" description-key="Size32" default="true">Size32</value>
+      <value name="Size40" display-name-key="Size40" description-key="Size40">Size40</value>
+      <value name="Size48" display-name-key="Size48" description-key="Size48">Size48</value>
+      <value name="Size56" display-name-key="Size56" description-key="Size56">size56</value>
+    </property>
+    <property name="OverflowButtonType" display-name-key="OverflowButtonType" description-key="OverflowButtonType" usage="input" of-type="Enum" required="true">
+      <value name="none" display-name-key="none" description-key="none">none</value>
+      <value name="descriptive" display-name-key="descriptive" description-key="descriptive" default="true">descriptive</value>
+      <value name="downArrow" display-name-key="downArrow" description-key="downArrow">downArrow</value>
+      <value name="more" display-name-key="more" description-key="more">more</value>
+    </property>
+
+    <!-- Dataset Property -->
+    <data-set name="items" display-name-key="Items">
+      <property-set name="ItemPersonaName" display-name-key="ItemPersonaName" of-type="SingleLine.Text" usage="bound" required="true" />
+      <property-set name="ItemPersonaKey" display-name-key="ItemPersonaKey" of-type="SingleLine.Text" usage="bound" required="true" />
+      <property-set name="ItemPersonaImage" display-name-key="ItemPersonaImage" of-type="File" usage="bound" required="false" />
+      <property-set name="ItemPersonaImageInfo" display-name-key="ItemPersonaImageInfo" of-type="SingleLine.Text" usage="bound" required="false" />
+      <property-set name="ItemPersonaPresence" display-name-key="ItemPersonaPresence" of-type="SingleLine.Text" usage="bound" required="false" />
+      <property-set name="IsImage" display-name-key="IsImage" of-type="TwoOptions" usage="bound" required="false" />
+      <property-set name="ItemPersonaClickable" display-name-key="ItemPersonaClickable" of-type="TwoOptions" usage="bound" required="false" />
+    </data-set>
+
+    <!-- InputEvent : SetFocus -->
+    <property name="InputEvent" display-name-key="InputEvent" of-type="SingleLine.Text" usage="input" />
+    <resources>
+      <code path="index.ts" order="1" />
+      <resx path="strings/Facepile.1033.resx" version="1.0.0" />
+      <platform-library name="React" version="16.8.6" />
+      <platform-library name="Fluent" version="8.29.0" />
+    </resources>
+  </control>
+</manifest>
diff --git a/Facepile/Facepile/ManifestConstants.ts b/Facepile/Facepile/ManifestConstants.ts
@@ -0,0 +1,31 @@
+export const enum ManifestPropertyNames {
+    dataset = 'dataset',
+}
+
+export const enum ItemColumns {
+    DisplayName = 'ItemPersonaName',
+    Key = 'ItemPersonaKey',
+    ImageUrl = 'ItemPersonaImageUrl',
+    Image = 'ItemPersonaImage',
+    ImageInfo = 'ItemPersonaImageInfo',
+    Role = 'ItemPersonaRole',
+    ImageType = 'ItemImageType',
+    Presence = 'ItemPersonaPresence',
+    Clickable = 'ItemPersonaClickable',
+    IsImage = 'IsImage',
+}
+
+export const enum InputEvents {
+    SetFocus = 'SetFocus',
+}
+
+export const enum InputProperties {
+    InputEvent = 'InputEvent',
+    SelectedKey = 'SelectedKey',
+}
+
+export const enum OutputEvents {
+    PersonaEvent = 'PersonaEvent',
+    OverFlowButtonEvent = 'OverFlowButtonEvent',
+    AddButtonEvent = 'AddButtonEvent',
+}
diff --git a/Facepile/Facepile/__mocks__/mock-context.ts b/Facepile/Facepile/__mocks__/mock-context.ts
@@ -0,0 +1,92 @@
+/* istanbul ignore file */
+
+export class MockContext<T> implements ComponentFramework.Context<T> {
+    constructor(parameters: T) {
+        this.parameters = parameters;
+        this.mode = {
+            allocatedHeight: -1,
+            allocatedWidth: -1,
+            isControlDisabled: false,
+            isVisible: true,
+            label: '',
+            setControlState: jest.fn(),
+            setFullScreen: jest.fn(),
+            trackContainerResize: jest.fn(),
+        };
+        this.client = {
+            disableScroll: false,
+            getClient: jest.fn(),
+            getFormFactor: jest.fn(),
+            isOffline: jest.fn(),
+        };
+
+        // Canvas apps currently assigns a positive tab-index
+        // so we must use this property to assign a positive tab-index also
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        (this as any).accessibility = { assignedTabIndex: 0 };
+    }
+    client: ComponentFramework.Client;
+    device: ComponentFramework.Device;
+    factory: ComponentFramework.Factory;
+    formatting: ComponentFramework.Formatting;
+    mode: ComponentFramework.Mode;
+    navigation: ComponentFramework.Navigation;
+    resources: ComponentFramework.Resources;
+    userSettings: ComponentFramework.UserSettings;
+    utils: ComponentFramework.Utility;
+    webAPI: ComponentFramework.WebApi;
+    parameters: T;
+    updatedProperties: string[] = [];
+}
+
+export class MockState implements ComponentFramework.Dictionary {}
+
+export class MockStringProperty implements ComponentFramework.PropertyTypes.StringProperty {
+    constructor(raw?: string | null, formatted?: string | undefined) {
+        this.raw = raw ?? null;
+        this.formatted = formatted;
+    }
+    raw: string | null;
+    attributes?: ComponentFramework.PropertyHelper.FieldPropertyMetadata.StringMetadata | undefined;
+    error: boolean;
+    errorMessage: string;
+    formatted?: string | undefined;
+    security?: ComponentFramework.PropertyHelper.SecurityValues | undefined;
+    type: string;
+}
+
+export class MockWholeNumberProperty implements ComponentFramework.PropertyTypes.WholeNumberProperty {
+    constructor(raw?: number | null, formatted?: string | undefined) {
+        this.raw = raw ?? null;
+        this.formatted = formatted;
+    }
+    attributes?: ComponentFramework.PropertyHelper.FieldPropertyMetadata.WholeNumberMetadata | undefined;
+    raw: number | null;
+    error: boolean;
+    errorMessage: string;
+    formatted?: string | undefined;
+    security?: ComponentFramework.PropertyHelper.SecurityValues | undefined;
+    type: string;
+}
+
+export class MockEnumProperty<T> implements ComponentFramework.PropertyTypes.EnumProperty<T> {
+    constructor(raw?: T, type?: string) {
+        if (raw) this.raw = raw;
+        if (type) this.type = type;
+    }
+    type: string;
+    raw: T;
+}
+
+export class MockTwoOptionsProperty implements ComponentFramework.PropertyTypes.TwoOptionsProperty {
+    constructor(raw?: boolean) {
+        if (raw) this.raw = raw;
+    }
+    raw: boolean;
+    attributes?: ComponentFramework.PropertyHelper.FieldPropertyMetadata.TwoOptionMetadata | undefined;
+    error: boolean;
+    errorMessage: string;
+    formatted?: string | undefined;
+    security?: ComponentFramework.PropertyHelper.SecurityValues | undefined;
+    type: string;
+}