-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove _T dependency #3903
remove _T dependency #3903
Conversation
promptflow SDK CLI Azure E2E Test Result jan25/pf/bugfix/no-marshmallow-t0 tests 0 ✅ 0s ⏱️ Results for commit 4b80f0c. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result jan25/pf/bugfix/no-marshmallow-t6 tests 6 ✅ 1m 20s ⏱️ Results for commit 4b80f0c. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result jan25/pf/bugfix/no-marshmallow-t798 tests 798 ✅ 3m 43s ⏱️ Results for commit 4b80f0c. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result jan25/pf/bugfix/no-marshmallow-t245 tests 239 ✅ 5m 11s ⏱️ Results for commit 4b80f0c. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result jan25/pf/bugfix/no-marshmallow-t 3 files 3 suites 48m 5s ⏱️ For more details on these failures, see this check. Results for commit 4b80f0c. ♻️ This comment has been updated with latest results. |
/check-enforcer override |
sorry for the breakage 😬 . this is the correct fix. just a heads up: the TypeVars in marshmallow (and any library) should not be imported in userland |
Marshmallow 3.24 dropped today, and removed the _T import, which broke PF. This pr fixes that hopefully. https://pypi.org/project/marshmallow/#history