Move kiosk game list to targetconfig.json #6122
Conversation
| "imageUrl": "/static/tutorials/pizza-party/pizza-party-img.png", | ||
| "largeImageUrl": "/static/tutorials/pizza-party/tmnt.gif" | ||
| "imageUrl": "/static/tutorials/pizza-party/playtime.png", | ||
| "largeImageUrl": "/static/tutorials/pizza-party/playtime.png" |
There was a problem hiding this comment.
Is this just an automated change?
There was a problem hiding this comment.
Yes. Sometimes they just happen. I'm not sure what triggers them.
There was a problem hiding this comment.
iirc this file is generated on pxt serve going through and grabbing the first thing in each row, so will update whenever that changes
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "TODO: Delete this file after the next Arcade release": 1, | |||
There was a problem hiding this comment.
I'm guessing you can't delete this now because it's still being used?
There was a problem hiding this comment.
Changes to the docs folder take affect almost immediately, and that can impact the current release. The released version of kiosk doesn't reference this file, so it would be fine. The beta version does though. Not the end of the world. Bumping beta would fix that.
| "imageUrl": "/static/tutorials/pizza-party/pizza-party-img.png", | ||
| "largeImageUrl": "/static/tutorials/pizza-party/tmnt.gif" | ||
| "imageUrl": "/static/tutorials/pizza-party/playtime.png", | ||
| "largeImageUrl": "/static/tutorials/pizza-party/playtime.png" |
There was a problem hiding this comment.
iirc this file is generated on pxt serve going through and grabbing the first thing in each row, so will update whenever that changes
targetconfig.json
Outdated
| "id": "_Y8VUmcHYsdsy", | ||
| "name": "GalgaMulti", | ||
| "description": "Controlling a starship, both players will destroy the Galga forces, while avoiding enemies. Each player has 3 lives, game ends once a player runs out of lives.", | ||
| "highScoreMode": "SingleAscending" |
There was a problem hiding this comment.
nit: prefer indenting but that's only for readability / doesn't really matter if you don't feel like doing it
…crosoft/pxt-arcade into eanders-ms/kiosk-targetconfig
* Move kiosk game list to targetconfig.json * fix indenting
* Add kiosk-data docs folder (#6009) * Remove /kiosk site, redirect to /--kiosk. (#6030) * Remove built kiosk from docs * Add redirect for kiosk * Remove kiosk.html * Remove old kiosk sources (#6036) * Move kiosk sfx to arcade repo (#6068) * Kiosk: Run high pass filter on UI audio (#6081) * Move kiosk game list to targetconfig.json (#6122) * Move kiosk game list to targetconfig.json * fix indenting * Bump pxt-arcade-sim -> v0.11.9 * bump pxt-core -> 8.5.54 * projects.md * Revert "Remove kiosk.html" This reverts commit 0b1189c. * Revert "Remove built kiosk from docs" This reverts commit 5d52d2b. * bump pxt-core -> 8.5.55
Companion PR in pxt: microsoft/pxt#9723