use getDate not getDay and simplify date logic #10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Sep 12, 2024
thsparks
approved these changes
Sep 12, 2024
riknoll
added a commit
that referenced
this pull request
Sep 12, 2024
abchatra
pushed a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#5935
turns out the
getDay()method returns the index of the day of the week not the day of the month! I guess those just happened to coincide last week while i was testing this ¯\_(ツ)_/¯the correct method to use is the confusingly named
getDate()i also fixed up the 'x days ago' logic so that it's a little easier to read