Code

Teacher Tool: Change block display#10202

Code

Merged

thsparks merged 34 commits intomastermicrosoft/pxt:masterfrom thsparks/teachertool/change_block_displaymicrosoft/pxt:thsparks/teachertool/change_block_displayCopy head branch name to clipboardSep 26, 2024

+316-42

Commits

Commits on Sep 13, 2024

• In progress still getting things working...

  thsparks

  committed
  be86d7c

Commits on Sep 14, 2024

• Some display changes

  thsparks

  committed
  30dff95

Commits on Sep 19, 2024

• Merge branch 'master' of https://github.com/microsoft/pxt into thsparks/teachertool/change_block_display

  thsparks

  committed
  a5f5c7a

• TIdy code

  thsparks

  committed
  fc0c083

• Attempt to handle blocks with no "parts" attribute. Seems like these blocks are defined a bit differently in blocks.ts and/or blockSnippets.ts? Idk this doesn't feel like a good solution...

  thsparks

  committed
  ae159cd

Commits on Sep 20, 2024

• Merge branch 'master' of https://github.com/microsoft/pxt into thsparks/teachertool/change_block_display

  thsparks

  committed
  9763e5b

• Comment update

  thsparks

  committed
  8af2714

• Refactor getBlockReadableName to getReadableBlockName

  thsparks

  committed
  8bce495

• Merge branch 'master' of https://github.com/microsoft/pxt into thsparks/teachertool/change_block_display

  thsparks

  committed
  466d31d

• Cache readable block names

  thsparks

  committed
  12739c2

• Move getBlockDescription and getSnippetName into new file

  thsparks

  committed
  7768d0e

• ReadableBlockName -> BlockTextParts

  thsparks

  committed
  2290097

• Move getBlockTextPartsFromBlocksBlockDefinition into helpers

  thsparks

  committed
  f974f56

Commits on Sep 21, 2024

• Refactor monacoFlyout to use shared getBlockTextParts function

  thsparks

  committed
  ab84d3d

• Don't cache for now (just because I need it uncached for testing)

  thsparks

  committed
  b74e8ba

• Replace all params with value

  thsparks

  committed
  df4b703

Commits on Sep 24, 2024

• Add snippet names for blocks

  thsparks

  committed
  944acd7

• Use snippet names as fallback

  thsparks

  committed
  c131bfb

• Styling adjustments

  thsparks

  committed
  6bf02b1

• Different name for the square root (and other operations) block. I struggled to figure out what to call this one, opted for the simplest approach which is just to include a subset of the options in…

  Show description for 7799b36
  thsparks

  committed
  7799b36

• Re-include caching logic

  thsparks

  committed
  7b5a829

• Remove unnecessary code movement change

  thsparks

  committed
  d228a56

• Minor code cleanup

  thsparks

  committed
  dbe3493

• Only rely on blockId (not blockData) to display the readable component. This way we don't have to wait for the toolbox info to display cached results.

  thsparks

  committed
  39a8500

Commits on Sep 25, 2024

• Clean up code in app.tsx

  thsparks

  committed
  1de0863

• Do not show duplicate names

  thsparks

  committed
  b19ddac

• Remove shared use of getSnippetName. It was causing more complexity than it removed.

  thsparks

  committed
  d0f5fa0

• Update some block snippets

  thsparks

  committed
  fbeefda

• blockTextParts -> blockAsText

  thsparks

  committed
  cae7c4d

• Remove unnecessary newline

  thsparks

  committed
  d6673d8

• Fix typo

  thsparks

  committed
  5e56afc

• Prettier

  thsparks

  committed
  0ba72f2

• Remove unnecessary Promise.resolve

  thsparks

  committed
  52da0b9

• Use var for shadow color

  thsparks

  committed
  2864ed9