Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field_userenum.ts #9654

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jp-96
Copy link

@jp-96 jp-96 commented Aug 24, 2023

Data binding fails.
#9653

Console warning:
Cannot set the dropdown's value to an unavailable option. Block type: radioMessageCode, Field name: MEMBER, Value: add1

Data binding fails.
microsoft#9653

Console warning:
Cannot set the dropdown's value to an unavailable option.
Block type: radioMessageCode, Field name: MEMBER, Value: add1
Copy link
Member

@jwunderl jwunderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me; this also fixes microsoft/pxt-arcade#6037, I believe you re-filed it this morning after I moved it over to arcade last night (we typically track / prioritize bugs we can see in the editors themselves as they make it easier to repro / identify how many people are affected by them, so when possible it's best to file an issue in pxt-arcade or pxt-microbit even if it affects all editors.)

Here's a test project for anyone else who wants to review, swap around the order of red / yellow / blue in typescript then switch to blocks to induce the error: https://makecode.microbit.org/_gPUFdTT0s1zu

pxtblocks/fields/field_userenum.ts Outdated Show resolved Hide resolved
@jwunderl jwunderl requested a review from a team August 24, 2023 17:50
@jp-96
Copy link
Author

jp-96 commented Aug 25, 2023

we typically track / prioritize bugs we can see in the editors themselves as they make it easier to repro / identify how many people are affected by them, so when possible it's best to file an issue in pxt-arcade or pxt-microbit even if it affects all editors.

I understand,
Thank you.

Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants