Force version history to update when restoring a version or sharing #9718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsparks
approved these changes
Oct 12, 2023
| @@ -375,6 +375,51 @@ namespace pxt.workspace { | |||
| toWrite[pxt.HISTORY_FILE] = JSON.stringify(history); | |||
| } | |||
|
|
|||
| export function pushSnapshotOnHistory(text: ScriptText, currentTime: number) { | |||
There was a problem hiding this comment.
in saveSnapshotAsync in workspace.ts
srietkerk
reviewed
Oct 12, 2023
| @@ -375,6 +375,51 @@ namespace pxt.workspace { | |||
| toWrite[pxt.HISTORY_FILE] = JSON.stringify(history); | |||
| } | |||
|
|
|||
| export function pushSnapshotOnHistory(text: ScriptText, currentTime: number) { | |||
| let history: pxt.workspace.HistoryFile; | |||
There was a problem hiding this comment.
Not super necessary, and there might also be something that I'm missing, but have you considered putting this let history .. if .. else.. chunk in a separate function to limit repeated code?
There was a problem hiding this comment.
it's slightly different in each function, sadly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/pxt-minecraft/issues/2356
Three version history fixes: