New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indices check for pop operation in Python #9721

Merged

kimprice merged 1 commit into master from kim-pop

Oct 13, 2023

Contributor

kimprice commented Oct 13, 2023

fixes https://github.com/microsoft/pxt-minecraft/issues/2024

We were throwing an Index Error when trying to pop the 0th element because our check didn't include 0 as a valid index.


          fix indices check

4dc3a3d

kimprice requested a review from a team

October 13, 2023 22:34

abchatra approved these changes

View reviewed changes

kimprice merged commit ae5ff1e into master

kimprice deleted the kim-pop branch

October 13, 2023 22:48

Contributor Author

kimprice commented Oct 13, 2023

Whoops, accidentally linked the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet