Editor tour: add play button for Minecraft #9771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Nov 2, 2023
srietkerk
reviewed
Nov 2, 2023
| @@ -29,6 +29,9 @@ function getTargetMap(target: string): querySelector { | |||
| "download": { | |||
| targetQuery: "#downloadArea", | |||
| }, | |||
| "play button" : { | |||
There was a problem hiding this comment.
Will there be any problems with having a space in this name? Not sure how these are parsed.
There was a problem hiding this comment.
^ I had the same thought but the ones just above also have spaces and are working fine~
There was a problem hiding this comment.
Yea good question, it works fine with the space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the editor tour in Minecraft, we need to include the play button which is specific to Minecraft.