-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate auto imports for core callables #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
requested review from
billti,
idavis,
minestarks and
ScottCarda-MS
as code owners
August 19, 2024 22:41
Benchmark for 5f0ee5aClick to view benchmark
|
Benchmark for 13bae1fClick to view benchmark
|
Benchmark for fad84d1Click to view benchmark
|
swernli
approved these changes
Aug 19, 2024
billti
approved these changes
Aug 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 20, 2024
Benchmark for 6c9bedbClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1860
Currently, we have a separate code path for generating completions for core callables. This code path just hard-codes the callables to
not include any auto-generated imports. This may have been necessary at some point, but it no longer is and it is preventing us from generating
the correct auto-imports for
QIR.Runtime
. We now have a function that generates completions from a package and is aware of if imports areneeded or not, so I just went ahead and used that instead of special casing
Core
.This PR:
Core
QIR.Runtime.*
) and are not generated for items alreadyin scope (e.g.
Length
).